-
Notifications
You must be signed in to change notification settings - Fork 29
Bundle Analysis: Add mutation for toggling bundle caching configuration #1084
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
|
✅ All tests successful. No failed tests were found. 📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1084 +/- ##
==========================================
+ Coverage 96.02% 96.03% +0.01%
==========================================
Files 828 831 +3
Lines 19504 19557 +53
==========================================
+ Hits 18729 18782 +53
Misses 775 775
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| "bundles": [{"bundleName": "pr_bundle1", "toggleCaching": True}], | ||
| }, | ||
| ) | ||
| assert data == {"updateBundleCacheConfig": {"results": [], "error": None}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this return the bundles that were updated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nah this test is just to test the mutation, the UpdateBundleCacheConfigInteractor is being mocked, and that is being tested in the other test class.
closes codecov/engineering-team#3073
Add a mutation to update the bundle analysis cache config table.
Schema:
Example usage:
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.